Skip to content

Commit

Permalink
[Enhancement] Ranked talents should only show up in higher tiers if b…
Browse files Browse the repository at this point in the history
…ought at lower tiers #63 (#64)

- refactored logic to determine when to display ranked talents
- marked Bullrush as not ranked
- UndercityContactsImproved now correctly requires UndercityContacts

Co-authored-by: Kolja Markwardt <[email protected]>
  • Loading branch information
KoljaTM and koljatm-edeka authored Jun 6, 2021
1 parent be59d7c commit 6b0e9c5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions packages/emporium/src/app/components/TalentSelection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@ class TalentSelectionComponent extends React.Component<any, any> {
}
//talent is ranked and has been selected enough for this tier
if (
talents[key].ranked && talentCount[key]
? +tier !== +talents[key].tier + talentCount[key]
: false
talents[key].ranked && +tier !== +talents[key].tier + (+talentCount[key] || 0)
) {
return false;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/emporium/src/assets/data/talents/ROT.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"tier": 1,
"activation": true,
"turn": "Incidental",
"ranked": true,
"ranked": false,
"book": "ROT",
"page": "84",
"description": "See ROT, page 84, for more details."
Expand Down Expand Up @@ -866,4 +866,4 @@
"page": "91",
"description": "See ROT, page 91, for more details."
}
}
}
4 changes: 2 additions & 2 deletions packages/emporium/src/assets/data/talents/SOTB.json
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@
"activation": true,
"turn": "Incidental",
"ranked": false,
"prerequiste": "UndercityContacts",
"prerequisite": "UndercityContacts",
"book": "SOTB",
"page": 51,
"description": "See SOTB, page 51, for more details."
Expand Down Expand Up @@ -794,4 +794,4 @@
"page": 52,
"description": "See SOTB, page 52, for more details."
}
}
}

0 comments on commit 6b0e9c5

Please sign in to comment.