CURA-12313 Add argument to set actual number of output extruders #28
+72
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit e933710. ♻️ This comment has been updated with latest results. |
CURA-12313 We now need to initialize the exporter with the proper number of extruders before we can use it.
CURA-12313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makerbot Replicator+ requires that we don't mention the second extruder (b) in the jsontoolpath file. Thus we can now give the number of actual extruders to be exported to dulcificum.
Using an init method for this is not great, technically the settings list should be moved to a local variable instead of global static, and given to methods that require it. This requires a larger code change, but I would be ok with it, tell me what you think.
CURA-12313