Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clay ceramic 3D printing material for Eazao. #308

Closed
wants to merge 5 commits into from

Conversation

Eazao
Copy link
Contributor

@Eazao Eazao commented Jul 24, 2024

If there are any mistakes that were made, please don't hesitate to tell us and we'll fix them as soon as possible.

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jul 24, 2024
@HellAholic
Copy link
Contributor

Hey @Eazao ,
Sorry for the delay in response.
The printer definitions were included in the 5.9 Beta release on Tuesday (Oct 22), but the material definition you’re attempting to add wasn’t included.

Since the material definition only updates a few specific settings, it would be more effective to apply these adjustments directly within the printer definition. This approach minimizes potential conflicts from override settings. For example, the definition files currently disable retraction and set the print temperature to 0, so the material file isn’t adding significant value here.

Additionally, the printer definitions have the "has material" field set to false, which prevents material selection on these printers.

To incorporate these settings and changes for the initial release including Eazazo printers, we recommend adding them directly to the printer definition files. If you’d like to submit a PR, please base it on the 5.9 branch to reduce the chance of merge conflicts.

@Eazao
Copy link
Contributor Author

Eazao commented Oct 27, 2024

Hey @Eazao , Sorry for the delay in response. The printer definitions were included in the 5.9 Beta release on Tuesday (Oct 22), but the material definition you’re attempting to add wasn’t included.

Since the material definition only updates a few specific settings, it would be more effective to apply these adjustments directly within the printer definition. This approach minimizes potential conflicts from override settings. For example, the definition files currently disable retraction and set the print temperature to 0, so the material file isn’t adding significant value here.

Additionally, the printer definitions have the "has material" field set to false, which prevents material selection on these printers.

To incorporate these settings and changes for the initial release including Eazazo printers, we recommend adding them directly to the printer definition files. If you’d like to submit a PR, please base it on the 5.9 branch to reduce the chance of merge conflicts.

Hi HellAholic,

According to the suggestion, we changed the retract setting to "true" and changed "has material" to "true". At the same time, we submitted a request, which you can view here:
Ultimaker/Cura#19818

Excuse me, can this material request we submitted be added to cura?

Are there any problems with this material request submitted at present, and what do we need to do? Please let us know at any time.

@HellAholic HellAholic changed the base branch from master to add_eazao_clay October 30, 2024 15:08
@HellAholic
Copy link
Contributor

I made a PR on the 5.9 branch for the material
#324
closing this one in favor of the one above.
Side note, I've updated the file name to lowercase letters, the new materials added are in lowercase if it can be helped, mostly lint and style. Let me know if you agree with that.

@HellAholic HellAholic closed this Oct 30, 2024
@Eazao
Copy link
Contributor Author

Eazao commented Nov 2, 2024

I made a PR on the 5.9 branch for the material #324 closing this one in favor of the one above. Side note, I've updated the file name to lowercase letters, the new materials added are in lowercase if it can be helped, mostly lint and style. Let me know if you agree with that.

HellAholic Thank you for your suggestion. We totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants