Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new filament, VOXEPLA #222

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

VOXELPLA
Copy link

I have added 5 new colors of VOXELPLA with retraction and temp setting for the filament

Added 5 colors of VOXELPLA plus profiles
Added new VOXELPLA PLUS profiles
@VOXELPLA
Copy link
Author

This is my first time making a pull request. I am unsure if I am doing this correctly; please let me know if there are any issues.

Copy link
Contributor

@MariMakes MariMakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VOXELPLA,

There are a number of changes we request before merging this.
Can you please address them?
Thank you 😄

<label>VOXELPLA PLUS BLACK</label>
</name>
<version>8</version>
<GUID>da7d7354-792f-4e80-ac3b-59df1de531fa</GUID>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be Unique GUIDs.
Every material should haver its own Unique Modifier.
You can get one here:
https://www.guidgenerator.com/

Comment on lines +7 to +8
<color>BLACK</color>
<label>VOXELPLA PLUS BLACK</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only capitalize what needs capitalization.

Here I would suggest

Suggested change
<color>BLACK</color>
<label>VOXELPLA PLUS BLACK</label>
<color>Black</color>
<label>VOXELPLA PLA Plus Black</label>

<version>8</version>
<GUID>da7d7354-792f-4e80-ac3b-59df1de531fa</GUID>
<color_code>#000000</color_code>
<description>The most reliable PLA PLUS on the planet. Best printed with 200C on the extruder and 45-60C on the bed, minimal retraction is needed. Each spool is $16.99 on WWW.VOXELPLA.COM</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not helpful for users.
The bold claim that this is The Most Reliable PLA PLUS on the planet cannot be fact-checked.
Including the price and website is not a good idea since it's subject to change and can only be updated when shipped with a Cura release.
I suggest removing these mentions and making them a more nuanced message.

</properties>
<settings>
<setting key="print temperature">200</setting>
<setting key="heated bed temperature">60</setting>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most the printers that you included seem to have a heated bed temperature of 55.
If you change this value to

Suggested change
<setting key="heated bed temperature">60</setting>
<setting key="heated bed temperature">55</setting>

Then you can remove all the mentions of heated bed temperature in the printers and you adhere to the DRY principle:
https://www.plutora.com/blog/understanding-the-dry-dont-repeat-yourself-principle

Comment on lines +27 to +250
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Creality3D" product="creality_cr10s5" />
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Creality3D" product="creality_cr10s4" />
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Creality3D" product="creality_cr10s" />
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Creality3D" product="creality_cr10mini" />
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Creality3D" product="creality_cr10" />
<setting key="heated bed temperature">50.0</setting>
<setting key="standby temperature">180.0</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60.0</setting>
<setting key="retraction amount">5.0</setting>
</machine>
<machine>
<machine_identifier manufacturer="CreawsomeMod" product="creality_base" />
<setting key="heated bed temperature">50</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">60</setting>
<setting key="retraction amount">5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Cartesio bv" product="cartesio" />
<setting key="print temperature">190</setting>
<setting key="heated bed temperature">43</setting>
<setting key="standby temperature">160</setting>
<setting key="print cooling">40.0</setting>
<setting key="retraction speed">40</setting>
<hotend id="0.8mm thermoplastic extruder">
<setting key="hardware compatible">yes</setting>
<setting key="retraction amount">1.5</setting>
</hotend>
<hotend id="0.4mm thermoplastic extruder">
<setting key="hardware compatible">yes</setting>
<setting key="retraction amount">1.0</setting>
</hotend>
<hotend id="0.25mm thermoplastic extruder">
<setting key="hardware compatible">yes</setting>
<setting key="retraction amount">1.0</setting>
</hotend>
</machine>
<machine>
<machine_identifier manufacturer="BIQU" product="biqu_b1_abl" />
<setting key="print temperature">180</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
</machine>
<machine>
<machine_identifier manufacturer="BIQU" product="biqu_b1" />
<setting key="print temperature">180</setting>
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
</machine>
<machine>
<machine_identifier manufacturer="Kati Hal ARGE" product="alyanx3dp" />
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">40</setting>
<setting key="retraction amount">1.5</setting>
</machine>
<machine>
<machine_identifier manufacturer="Kati Hal ARGE" product="alya3dp" />
<setting key="standby temperature">180</setting>
<setting key="print cooling">100</setting>
<setting key="retraction speed">40</setting>
<setting key="retraction amount">1.5</setting>
</machine>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not have to repeat every printer definition if the settings are the same.

If you check:
https://github.com/Ultimaker/fdm_materials/blob/master/redd_pla.xml.fdm_material
You can see that they removed the machine definitions and it's still available for all 1.75 printers in Cura.

If you know the specific settings of each printer and they are indeed different, you should keep them in.

@jellespijker jellespijker added the PR: Community Contribution 👑 Community Contribution PR's label Nov 30, 2022
@Joeydelarago Joeydelarago marked this pull request as draft December 30, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants