Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created material profiles for FILAMEON PLA and ABS #147

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bizgi
Copy link

@bizgi bizgi commented Oct 25, 2020

FILAMEON is filament manufacturer in Turkey.

FILAMEON is filament manufacturer in Turkey.
@nallath
Copy link
Member

nallath commented Oct 27, 2020

These profiles are just exact copies of the generic profiles. I don't really see the advantage of merging these in.

@Ghostkeeper
Copy link
Contributor

I mean, so are Ultimaker's materials... But it does raise the issue of whether these profiles have actually been tested.

@nallath
Copy link
Member

nallath commented Oct 29, 2020

Sure, but those at least have colors set. These are still set to be generic...

@bizgi
Copy link
Author

bizgi commented Oct 29, 2020

It's a reasonable point that these profiles are the same as the generic ones. But as a user, I think it's practical to just choose the filament brand and start printing without thinking about the material settings.

In addition, these profiles have been tested on Ultimaker 2+ and Ender 3 pro.

@Ghostkeeper
Copy link
Contributor

Ghostkeeper commented Nov 2, 2020

All right, well I think there is one thing we can do to make it more consistent, because one metadata field is inconsistent at the very least: UUID.
The UUID is supposed to refer to a specific spool as needs to be identified by the printer (since it was designed to be read by the printer firmware using an RFID tag). The printer typically wants to identify colour as well. So I think it would make sense to copy the profiles to be one profile for each colour, but each with their own UUID. This could be a bit of work (I see that Filameon apparently offers 18 colours of PLA and 17 colours of ABS). But it would also resolve the inconsistency of having a "generic PLA" but specific to a brand.

There is also the matter of whether to place these in the Marketplace or here. We don't often get 2.85mm filaments. Other materials for Ultimaker printers are currently in the Marketplace. Those are being reviewed by Ultimaker's material team, so maybe they'd want to review this too, but it's strange that this gets pre-installed automatically. On the other hand, this material would be confusing in the Marketplace as long as the Marketplace doesn't indicate what printers the material is compatible with (which is still on our ToDo list to implement).
We'll have to take up this matter with the Materials team I think.

@Ghostkeeper
Copy link
Contributor

These profiles don't override any settings used by the UM2+ which is probably why they still work just as fine.

@jellespijker jellespijker added the PR: Community Contribution 👑 Community Contribution PR's label Nov 30, 2022
@Joeydelarago Joeydelarago marked this pull request as draft December 30, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants