CURA-12352 different minimum layer time for layers that contain overhangs #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wawanbreton
changed the title
…ang' into CURA-12352_different-minimum-layer-time-for-layers-that-contain-overhangs
…er-time-for-layers-that-contain-overhangs' into CURA-12352_different-minimum-layer-time-for-layers-that-contain-overhangs
…fferent-minimum-layer-time-for-layers-that-contain-overhangs
Even if the overhang wall speed is set to 100%, and thus wouldn't normally change, the minimum layer time for overhanging walls (split off from the minimum layer time, which is the whole point of this ticket) still should take effect -- which we can't detect if the merged regions are just one big everything blob. part of CURA-12352
done as part of CURA-12352
Since the speed regions can 'too' small as well, we need to make sure we don't create microsegments -- While there was already a mitigation earlier, Ihad to partially undo that to fix a bug, and now it's done in a more guaranteed, explicit way. part of CURA-12352
…layers-that-contain-overhangs
wawanbreton
commented
Jan 20, 2025
| | ranges::views::chunk_by( | ||
| [](const auto& region_a, const auto& region_b) | ||
| { | ||
| return region_a.chunk && region_b.chunk && region_a.speed_factor == region_b.speed_factor; |
There was a problem hiding this comment.
I'm sure there is a good reason for not merging the internal area, but I would be curious to know it 😃
| } | ||
|
|
||
| // (Also) Avoid microsegments: Filter out pairs of intersections that are too close to each other. | ||
| // This should be possible because the intersections happen in the same region. |
There was a problem hiding this comment.
I don't really understand why this should work. According to me, it shouldn't because in the next step, you always assume that you are moving from a region to an adjacent one. But not you filter our intersections, which means you can move from a region to any other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12352
Requires Ultimaker/Cura#20039