Skip to content

[ROBO-5186] Fix duplicate stacktraces in logging #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduard-dumitru wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −3
Open

[ROBO-5186] Fix duplicate stacktraces in logging #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9547b0
fixed
eduard-dumitru Dec 9, 2025
88ebbf0
fix race condition leading to potential crashes during disposal la Ip…
eduard-dumitru Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UiPath.CoreIpc/Helpers/Helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal static void LogException(this ILogger? logger, Exception ex, object tag

if (logger is not null)
{
logger.LogError(ex, message);
logger.LogError(message);
return;
}

Expand Down
19 changes: 17 additions & 2 deletions src/UiPath.CoreIpc/Transport/NamedPipe/NamedPipeServerTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Newtonsoft.Json;
using System.IO.Pipes;
using System.Runtime.InteropServices;
using System.Security.Principal;

namespace UiPath.Ipc.Transport.NamedPipe;
Expand Down Expand Up @@ -79,16 +80,30 @@ ValueTask IAsyncDisposable.DisposeAsync()
#endif
}

private static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);

async ValueTask<Stream> IServerConnectionSlot.AwaitConnection(CancellationToken ct)
{
if (IsWindows)
{
await Stream.WaitForConnectionAsync(ct);
return Stream;
}

// on Linux WaitForConnectionAsync has to be cancelled with Dispose
using (ct.Register(StartDisposal))
{
await Stream.WaitForConnectionAsync(ct);
try
{
await Stream.WaitForConnectionAsync();
}
catch (ObjectDisposedException)
{
}
return Stream;
}

void StartDisposal() => (this as IAsyncDisposable).DisposeAsync().AsTask().TraceError(); // We trace the error even we don't expect Dispose/DisposeAsync to ever throw.
void StartDisposal() => (this as IAsyncDisposable).DisposeAsync().AsTask().TraceError(); // We trace the error even though we don't expect Dispose/DisposeAsync to ever throw.
}
}
}