Skip to content

changed os check to compile time#3

Merged
mymindstorm merged 2 commits intomainfrom
ameya/os-redesign
Mar 4, 2025
Merged

changed os check to compile time#3
mymindstorm merged 2 commits intomainfrom
ameya/os-redesign

Conversation

@AmeyaPurao
Copy link
Collaborator

No description provided.

@AmeyaPurao AmeyaPurao requested a review from mymindstorm March 3, 2025 22:19
Copy link
Member

@mymindstorm mymindstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the *_linux.go and *_windows.go. We can ditch the windows/ and linux/ dirs.

The entrypoint (triage/triage.go) should not be platform specific. I feel like this moves us too close to the direction of having two different programs in one codebase. For triage, we are collecting the very similar information across both platforms, it's just that we use different methods to collect that information per-platform. For example:

// triage.go

func Run() {
  var err Error
  err = printUsers()
  err = printIpv4()
  // ...
}

// users_linux.go
func printUsers() { /* ... */ } 

// users_windows.go
func printUsers() { /* ... */ } 

@AmeyaPurao AmeyaPurao requested a review from mymindstorm March 4, 2025 01:32
@mymindstorm mymindstorm merged commit d9d5118 into main Mar 4, 2025
1 check passed
@AmeyaPurao AmeyaPurao deleted the ameya/os-redesign branch March 4, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants