Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBAR_proxy and added/fixed documentation for 19 emi scripts #28

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

burnettear
Copy link
Collaborator

New Proxies

  1. task_fbar_proxy
  • I initially attempted to parameterize the pytask function to apply to all 7 proxies, but @parameterize is outdated. When I attempted to loop the pytask function (I found updated documentation online), it did not work and just created the same proxy 7 times regardless of changes to parameters. I adjusted to creating a proxy function and creating 7 pytask functions applying the base function. The base function fails (I've attempted to not have it run as a pytask, unsuccessfully), but the 7 proxies output correctly.

Updated Emis (with documentation)

  1. task_abandoned_og_wells
  2. task_anaerobic_digestion
  3. task_coal_surf_emi
  4. task_coal_under_emi
  5. task_dom_wastewater_emi
  6. task_forest_land_emi
  7. task_grassland_emi
  8. task_ind_wastewater_emi
  9. task_land_converted_to_wet_emi
  10. task_livestock_enteric_fermentation
  11. task_livestock_manure_management
  12. task_mobile_comb_emi
  13. task_ng_prod_water_and_not_mapped_emi
  14. task_petro_exploration_emi
  15. task_petro_production_emi
  16. task_petro_refining_emi
  17. task_petro_transport_emi
  18. task_stat_comb_emi
  19. task_wetland_rem_wet_emi

# %% Proxy Functions


def create_circle_geometry(row, radius_crs="EPSG:3857"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this to use the EQ_AREA_CRS in config.py

Copy link
Collaborator

@nkruskamp nkruskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistake comment.

Copy link
Collaborator

@nkruskamp nkruskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnettear did John move the emi files already to the emi_processing module in the code, and does this merge need to reflect that these files are updated versions of the ones he moved? Can you check main and compare the files you've modified here with the ones he's moved into emi_processing?

@burnettear
Copy link
Collaborator Author

@burnettear did John move the emi files already to the emi_processing module in the code, and does this merge need to reflect that these files are updated versions of the ones he moved? Can you check main and compare the files you've modified here with the ones he's moved into emi_processing?

@nkruskamp It looks like John moved the emi files to the emi_processing module in the main branch. This merge would need to update those files (now housed in emi_processing) and not create new files in the emi_mapping/adjusted_code directory they were pushed from. Please advise on next steps.

@nkruskamp nkruskamp changed the base branch from main to consolidate_emis_files January 15, 2025 22:36
@nkruskamp nkruskamp changed the base branch from consolidate_emis_files to main January 15, 2025 22:55
@nkruskamp nkruskamp merged commit 7d0e8da into main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants