Au ml crosswalk #562
Open
Au ml crosswalk #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo causing errors
Potential bug fix
Bug fix, update message text
switched message to a stop rather than print if no correct org id is supplied, draft function to create crosswalk between org id and ml id (maybe for dev use only?)
Updated data links section
reorganizing function steps to make more efficient (don't pull in ATTAINS data unless necessary)
use TADA_CheckColumns
Updates to function order for efficiency, styler updates
typo corrections
Styler updates and minor formatting revisions to correct check error messages
corrected return issue
changed activity relative depth ref table prefix name to it is internal to TADA package, not created from WQX web services, used csv instead of get functions in new functions, added new TADA_Get functions to maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft functions related to monitoring location/Assessment Unit crosswalks:
TADA_GetAssessmentUnitCrosswalk - using ATTAINS webservices, creates a crosswalk between Assessment Units and all Monitoring Locations recorded for them in ATTAINS
TADA_GetMonLocByOrgId - create a df of MonitoringLocationIdentifier and OrganizationIdentifier to help w/ finalizing user created crosswalk (not sure if this is necessary? I was using it to help create test crosswalks)
TADA_GetProviderRef - using WQX web services to create a ref file for the ProviderName for each Organizations (used later on to build the URLs for each MonitoringLocation to link to the WQP site pages)
TADA_UpdateProviderRef - update the provider ref csv file saved in the package
TADA_UpdateMonitoringLocationsInATTAINS - use a user-supplied Monitoring Location crosswalk w/ the ATTAINS created crosswalk to create a df to update Monitoring Location info in ATTAINS. I have not yet set up this function to save as a csv. I am thinking that as we will likely be setting up a number of similar functions in the future a TADA_CreateCSV function might be useful to create for the simple batch import csvs (in constrast to the complex mod 3 Excel files, which will need the more complicated export and formatting code built into each of those functions)