-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add level 3 method resp.censormed.neg25 #301
Open
cthunes
wants to merge
11
commits into
dev
Choose a base branch
from
add-mc3-method-resp.censormed.neg25
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add r cmd check yaml to actions workflows
…://github.com/USEPA/CompTox-ToxCast-tcpl into 189-tcplsubsetchid-overwrites-hitc-to-boolean merge with dev for new actions yaml check
…-to-boolean update mc overwrite of hitc to bool in tcplSubsetChid to actc
…com/USEPA/CompTox-ToxCast-tcpl into add-mc3-method-resp.censormed.neg25 merge branch with dev for new github actions check
madison-feshuk
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steve approves of using the censoring to -25 on proliferation assays. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added resp.censormed.neg25 (mc3_mthd_id: 50) with description:
"Censor (remove) response values from concentrations which median falls below -25."
This will be a method which ordr matters -- it must be after whichever 'resp' method is chosen, since medians are calculated from 'resp'. If we'd prefer to not have to use ordr and would instead would want to do like we have for a couple other levels with "ow" methods occuring after all other methods, let me know and that'd be a simple change.
Closes #299.