Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified old method to allow only specific models #138

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

brown-jason
Copy link
Collaborator

This is based on an old method, but untested so we will need to run it through for associated endpoints and modify if necessary.

brown-jason and others added 3 commits August 24, 2023 09:40
…133)

* changed uppercase parameter descriptions to lowercase so they match what is in the function call

* changed plot for page to plots per page

* indicated that lists of flags are not yet available

* indicate only multi-conc is supported

* indicate winning model is listed at the top of the table for verbose TRUE

* The goal of this section is to provide example quantitative metrics, such as z-prime and coefficient of variance, to evaluate assay performance relative to controls

* changed level 0 preprosessing to custom preprocessing step to match the diagram

* added text: defined in level 2

* removed section that mentions or an apparent negative response within a positively-analyzed, unidirectional endpoint because everything is fit bidirectionally now

* attempt to clarify zero centering and added a note about 0 values in the baseline

* removed extra space on overview figure

* updated hitcalling information based on manuscript text and continous hitcall discussions

* attempt to clarify pval section
@brown-jason brown-jason requested review from madison-feshuk and a team September 7, 2023 13:10
@brown-jason brown-jason linked an issue Sep 7, 2023 that may be closed by this pull request
@madison-feshuk
Copy link
Collaborator

@brown-jason can you rebase to the dev branch? I don't think I'd be able to test this given the mc4 column changes

@brown-jason brown-jason changed the base branch from main to dev September 7, 2023 14:52
@brown-jason
Copy link
Collaborator Author

@madison-feshuk I made this way harder than it needed to be but I believe I've successfully rebased to dev

@brown-jason
Copy link
Collaborator Author

If we squash and merge at the end nobody will know

Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padilla phenotype score data processed successfully. It seems to be working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc4_method bounded models only
2 participants