modified old method to allow only specific models #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…133) * changed uppercase parameter descriptions to lowercase so they match what is in the function call * changed plot for page to plots per page * indicated that lists of flags are not yet available * indicate only multi-conc is supported * indicate winning model is listed at the top of the table for verbose TRUE * The goal of this section is to provide example quantitative metrics, such as z-prime and coefficient of variance, to evaluate assay performance relative to controls * changed level 0 preprosessing to custom preprocessing step to match the diagram * added text: defined in level 2 * removed section that mentions or an apparent negative response within a positively-analyzed, unidirectional endpoint because everything is fit bidirectionally now * attempt to clarify zero centering and added a note about 0 values in the baseline * removed extra space on overview figure * updated hitcalling information based on manuscript text and continous hitcall discussions * attempt to clarify pval section
|
@brown-jason can you rebase to the dev branch? I don't think I'd be able to test this given the mc4 column changes |
…om/USEPA/CompTox-ToxCast-tcpl into 137-mc4_method-bounded-models-only
This reverts commit fcd4354.
|
@madison-feshuk I made this way harder than it needed to be but I believe I've successfully rebased to dev |
|
If we squash and merge at the end nobody will know |
madison-feshuk
approved these changes
Sep 7, 2023
brown-jason
added a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on an old method, but untested so we will need to run it through for associated endpoints and modify if necessary.