-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
62 bidirectional summary stats #126
Conversation
Saw following error writing Level 4:
|
logc_max = max(logc), logc_min = min(logc), nconc = length(unique(logc)), | ||
npts = .N, nrep = median(as.numeric(nconcs)), nmed_gtbl = sum(med_rmds) / first(nconcs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like nmed_gtbl might be dropped in code, but column is kept in the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Column has been dropped in invitrodb
Writing and loading data now accounting for new columns. I didn't change the columns for code using old schema, is this assumption correct? |
`:=`(fitparams = list(tcplfit2::tcplfit2_core(unlist(concentration_unlogged), | ||
unlist(response), | ||
cutoff = bmad, | ||
bidirectional = bidirectional, | ||
bidirectional = TRUE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthunes, was this changed from 'bidirectional' passed argument to TRUE since this the max_med_diff and max_med_diff_conc are only apply to the bidirectional = TRUE cases for right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind.... This is because we are only fitting in the bi-directional direction now within tcpl.
127 nmed gtbl mc6 flags
Including updated mc6 methods that formerly used nmed_gtbl in this PR. Closes #127 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with padilla processing! This is a huge update. I think we should merge this branch to dev, where we can continue testing
Added the following eight summary stats
Table schema for mc4 has been updated to reflect these new summary stats. Uploaded file to Clowder and tracked in schema_changes table. Closes #62.