Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

85 add bidirectional mc5 methods #123

Merged
merged 23 commits into from
Aug 30, 2023
Merged

Conversation

cthunes
Copy link
Contributor

@cthunes cthunes commented Aug 16, 2023

ow_bidirectional_loss and ow_bidirectional_gain have been added to mc5_mthds and mc5 has been updated to handle these ow methods after tcplHit is returned.

ow_bidirectional_loss overwrites winning model hitcall by multiplying by -1 for models fit in the positive analysis direction (top > 0). Typically used for endpoints where only negative responses are biologically relevant.
ow_bidirectional_gain overwrites winning model hitcall by multiplying by -1 for models fit in the negative analysis direction (top < 0). Typically used for endpoints where only positive responses are biologically relevant.

Closes #85 .

@cthunes cthunes marked this pull request as ready for review August 17, 2023 22:51
@cthunes
Copy link
Contributor Author

cthunes commented Aug 17, 2023

Hold on this, more testing needs to be done

@cthunes
Copy link
Contributor Author

cthunes commented Aug 18, 2023

Hold on this, more testing needs to be done

bug resolved, ready for reviewal!

Copy link
Contributor

@Ashley-Ko Ashley-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cthunes cthunes changed the base branch from main to dev August 21, 2023 17:02
Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge! We will continue testing on dev branch.

@cthunes cthunes merged commit 46a0479 into dev Aug 30, 2023
@cthunes cthunes deleted the 85-add-bidirectional-mc5-methods branch August 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ow_bidirectional_loss and ow_bidirectional_gain mc5 methods
3 participants