85 add bidirectional mc5 methods #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll by neg 1, removed potency metric NA assignments
|
Hold on this, more testing needs to be done |
bug resolved, ready for reviewal! |
Ashley-Ko
approved these changes
Aug 21, 2023
127 nmed gtbl mc6 flags
62 bidirectional summary stats
madison-feshuk
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ow_bidirectional_loss and ow_bidirectional_gain have been added to mc5_mthds and mc5 has been updated to handle these ow methods after tcplHit is returned.
ow_bidirectional_loss overwrites winning model hitcall by multiplying by -1 for models fit in the positive analysis direction (top > 0). Typically used for endpoints where only negative responses are biologically relevant.
ow_bidirectional_gain overwrites winning model hitcall by multiplying by -1 for models fit in the negative analysis direction (top < 0). Typically used for endpoints where only positive responses are biologically relevant.
Closes #85 .