Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
93 create vignette for tcplplot #114
93 create vignette for tcplplot #114
Changes from 3 commits
8774e0f
3a38603
0b7515b
5135569
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is there a maximum number of rows and columns that a user can set the output plots to be? That is, is the default multi plot 6 or 4 depending on the verbose parameter, then if a user wants more than that they can add it OR can users only define fewer plots displayed on the output multi plot? Basically what is the behavior of using multi, verbose, and nrow/ncol arguments together? Are there lower and upper bounds on various arguments being used together.
(Note: There does not need to be a whole lot of information but a concise summary of interdependencies/restrictions on these functional arguments may help users when they get started with tcplPlot.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madison-feshuk @brown-jason Is there an upper limit to nrow or ncol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no real limit that we've programmed into the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that exceeding more than two rows does not reduce the plot size, but rather increases the length of the page. (ncol increases page width) An upper bounds is forced by ggsave. I got this error when trying to run nrow = 10 or ncol = 9
Is it worth mentioning an upper bounds if there is not a hard coded limit?