Publish Scala package to Github packages#140
Merged
katrinafyi merged 9 commits intopartial_evalfrom Jul 8, 2025
Merged
Conversation
ailrst
reviewed
Jul 7, 2025
ailrst
left a comment
ailrst
left a comment
There was a problem hiding this comment.
Have you checked that mill supports downloading with the github read:packages token?
This looks fine though
ailrst
reviewed
Jul 7, 2025
| @@ -11,3 +11,22 @@ mill main.run --opcode 0x8b031041 | |||
| This should compile successfully. However, the last command will fail since | |||
katrinafyi
added a commit
to UQ-PAC/BASIL
that referenced
this pull request
Jul 8, 2025
Github packages provides a maven-compatible interface, so we can use mill's ivy fetching infrastructure. this will also fix the mill build. unfortunately, github requires a token in order to read packages - even if they're "public". i've hardcoded a read:packages token. this is probablyyyyyyy fine see: UQ-PAC/aslp#140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/UQ-PAC/aslp/packages/2571890.
downloading the package needs a github token which is a bit inconvenient. i was gonna embed a read-packages token into basil's mill files ;-;