Conversation
…r to int, may need a new IR operator to fix this but unsure at the moment
…ic offset from the addr, but the global offset
Contributor
|
scalafmt changes needed. options to apply scalafmt changes:run this command: echo 'From cebe5b72396161763fb57851dc8d0fd89483e4ed Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
<41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 28 Jan 2026 02:28:31 +0000
Subject: [PATCH] automated scalafmt
---
src/main/scala/ir/transforms/MemoryTransform.scala | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/main/scala/ir/transforms/MemoryTransform.scala b/src/main/scala/ir/transforms/MemoryTransform.scala
index 8f7b364..0ed42db 100644
--- a/src/main/scala/ir/transforms/MemoryTransform.scala
+++ b/src/main/scala/ir/transforms/MemoryTransform.scala
@@ -190,8 +190,3 @@ class MemoryTransform(dsa: Map[Procedure, IntervalGraph], globals: Map[IntervalN
ChangeTo(List(LocalAssign(lhs, resBV, store.label)))
- else
- ChangeTo(
- List(
- LocalAssign(LocalVar(name, store.value.getType), store.value, store.label)
- )
- )
+ else ChangeTo(List(LocalAssign(LocalVar(name, store.value.getType), store.value, store.label)))
else if !flag.escapes || isGlobal(flag) then
--
2.52.0' | git am -3or, trigger a workflow run on gh workflow run format.yml --field "autoformat=true" --ref 'mem-transform-bug'or, run the formatter locally: ./mill -i fmt |
Contributor
|
This approach isn't going to do anything to address the problem here. A more detailed explanation is here: #592 (comment) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #592.
Code is quiet ugly as Loads cannot be directly changed to a Extract, so BVSHL / BVLSHR are used instead to mediate this change.
TODO: