Skip to content

Conversation

MapTo0
Copy link
Contributor

@MapTo0 MapTo0 commented Sep 2, 2025

No description provided.

@nikoletavnv
Copy link
Contributor

// We have to implement the clear behavior because we have extra properties in the Search component that keep the input value
_handleClear(): void {
	super._handleClear();

	this._typedInValue = "";
	this._innerValue = "";
}

@nikoletavnv
Copy link
Contributor

nikoletavnv commented Sep 2, 2025

Issue 1: After pressing the clear icon, the focus stays in the search field and the suggestions stay open. After focusing out from the search and focusing in again, the suggestions are hidden and typing does not show them - this is probably related to setting this.open in onBeforeRendering but I could not find a case to make it work in all scenarios

Issue 2: In case old items are destroyed and new ones are created on input (both using timeout), the selection is set during OnAfterRendering before the slot items are invalidated and re-created. This causes the autocomplete to work with old items

Issue 3: Writing a text and pressing "search"icon causes different behavior when there is a suggestion and when there is no suggestion. When there is a suggestion - the popover is closed. When there is no suggestion - the popover remains open. The popover should close in both cases.

Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nikoletavnv
❌ MapTo0
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ nikoletavnv
❌ MapTo0
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants