Skip to content

Conversation

dobrinyonkov
Copy link
Contributor

@dobrinyonkov dobrinyonkov commented Aug 7, 2025

Fixes: #11687

Description

Refactors the List component's scroll growing functionality to use intersection observers with start/end markers instead of unreliable scroll height calculations and scroll container detection.

Background Problems

The existing scroll growing implementation had several issues:

Solution

Replaces the previous approach with:

  • Start marker: <span> element positioned at the beginning of the scroll container to track when user has scrolled down
  • End marker: <span> element positioned at the end to trigger load-more events
  • Viewport-based intersection observers: Two dedicated observers that detect marker visibility relative to the viewport
  • State management: _startMarkerOutOfView property to ensure container was scrolled down

Test Coverage

  • DOM presence tests for start/end markers
  • Intersection observer functionality validation
  • Edge case Readme links lead to 404 #1: Rerender scenarios that previously caused false events
  • Edge case docs(playground): fix typo #2: External scrollable containers that previously failed detection

@dobrinyonkov dobrinyonkov force-pushed the fix/list-scroll-growing-with-start-marker branch from d1c8b9c to 1cb9dcd Compare August 14, 2025 13:20
Copy link
Contributor

@NakataCode NakataCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dobrinyonkov dobrinyonkov reopened this Sep 5, 2025
Copy link

cla-assistant bot commented Sep 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Sep 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dobrinyonkov dobrinyonkov merged commit 8edc111 into main Sep 5, 2025
29 of 30 checks passed
@dobrinyonkov dobrinyonkov deleted the fix/list-scroll-growing-with-start-marker branch September 5, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<List> component growing="Scroll" no longer triggers scroll events after upgrade to 2.9.0+
2 participants