-
Notifications
You must be signed in to change notification settings - Fork 279
fix(ui5-list): growing with scroll improved #12087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d1c8b9c
to
1cb9dcd
Compare
…ng-with-start-marker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Fixes: #11687
Description
Refactors the List component's scroll growing functionality to use intersection observers with start/end markers instead of unreliable scroll height calculations and scroll container detection.
Background Problems
The existing scroll growing implementation had several issues:
False positive load-more events during rerender/content changes
Failed detection when List is inside external scrollable containers
Firefox issue solved by the new implementation as well
Solution
Replaces the previous approach with:
<span>
element positioned at the beginning of the scroll container to track when user has scrolled down<span>
element positioned at the end to trigger load-more events_startMarkerOutOfView
property to ensure container was scrolled downTest Coverage