Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-1209] Add EOLCheck and refactor project structure #51

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Conversation

ksclarke
Copy link
Member

  • Add a bounds checking method and test to csv_location.go (now location.go) file for reuse in all implementations of Validator
  • Create more directory structure for the project since it's getting larger (incorporated Angela's checks dir but put it in a validation dir).
  • Removed the .git from the module name (which is common practice, apparently)
  • Updated serviceName flag in TestContainers test (it wasn't being recognized anymore)
  • Added a validation check so I'd have something to test for my next ticket (and as a very simple example); it doesn't strictly require a profile but I added a NewEOLCheck method to illustrate what the idea was in terms of giving that information to the implementations.
  • Renamed some types now that their packages have changed (e.g. CsvLocation -> csv.Location)

@ksclarke ksclarke self-assigned this Jan 24, 2025
@ksclarke ksclarke requested a review from a team as a code owner January 24, 2025 22:17
@ksclarke ksclarke merged commit 9e882f8 into main Jan 27, 2025
2 checks passed
@ksclarke ksclarke deleted the SERV-1209 branch January 27, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants