Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditional slots to blockcardwithimage template #680

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

pghorpade
Copy link
Contributor

@pghorpade pghorpade commented Jan 30, 2025

Connected to APPS-3158

Component Updated: cardmeta.vue and blockcardwithimage.vue

Stories: ~/stories/cardmeta.stories.js and blockcardwithimage.stories.js

Notes:

Rename slot names , this will effect page template. Also added conditional slots check to blockcardwithimage

@pghorpade pghorpade added the bugfix Something isn't working label Jan 30, 2025
@pghorpade pghorpade self-assigned this Jan 30, 2025
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

@jendiamond jendiamond merged commit 6b43c1b into main Jan 30, 2025
11 checks passed
@jendiamond jendiamond deleted the APPS-3158 branch January 30, 2025 23:47
pghorpade pushed a commit that referenced this pull request Jan 30, 2025
# [3.46.0](v3.45.1...v3.46.0) (2025-01-30)

### Features

* add conditional slots to blockcardwithimage template ([#680](#680)) ([6b43c1b](6b43c1b))
@pghorpade
Copy link
Contributor Author

🎉 This PR is included in version 3.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants