feat: APPS-3089 Update StaffSubjectLibrarian components for FTVA #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
farosFreed
changed the title
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-674
tinuola
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
@farosFreed Looks good! And a great start to refactoring into a generic and dynamic table component! 👍🏾
|
Tinu caught that I had missed the class names for the elements surrounding the slots That has been added, thanks for the eagle eyes @tinuola! 
|
tinuola
approved these changes
Jan 23, 2025
pghorpade
pushed a commit
that referenced
this pull request
Jan 23, 2025
# [3.44.0](v3.43.7...v3.44.0) (2025-01-23) ### Features * APPS-3089 Update StaffSubjectLibrarian components for FTVA ([#674](#674)) ([a953ae2](a953ae2))
|
🎉 This PR is included in version 3.44.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3089
Component(s) Updated: BlockStaffSubjectLibrarian.vue, SectionStaffSubjectLibrarian.vue,
Stories: ~/stories/BlockStaffSubjectLibrarian.stories.js, ~/stories/SectionStaffSubjectLibrarian.stories.js, ~/stories/SectionWrapper.stories.js,
Notes:
This makes some changes to the BlockStaffSubjectLibrarian component to allow us to use it for Filmography data for the FTVA website.
BlockStaffSubjectLibrarian.vue, enabling it to wrap any content in table cells using slots.SectionStaffSubjectLibrarian.vueto allow another item type,FilmographyListItemTypeBlockStaffSubjectLibrarian.vue,SectionStaffSubjectLibrarian.vue, andSectionWrapper.vueto show implementation of ftva filmography section at every level of the processChecklist:
library-website-nuxt dev server