Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-1063] Add Codeowners file #6

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[SERV-1063] Add Codeowners file #6

merged 1 commit into from
Apr 4, 2024

Conversation

angelahuqing
Copy link
Contributor

Add CODEOWNERS

@ksclarke ksclarke changed the title SERV-1063 [SERV-1063] Add Codeowners file Apr 3, 2024
@ksclarke
Copy link
Member

ksclarke commented Apr 3, 2024

Looks like you're getting mixed PRs (with multiple tickets in them). I'm assuming it's because you're starting with your last ticket for the new work instead of going back to the main branch and create a new branch from that. Would you rework this so that we only have only ticket per PR?

@ksclarke ksclarke requested review from ksclarke and DRickard April 3, 2024 18:04
DRickard
DRickard previously approved these changes Apr 3, 2024
@angelahuqing angelahuqing marked this pull request as draft April 3, 2024 21:03
@angelahuqing angelahuqing self-assigned this Apr 3, 2024
@angelahuqing angelahuqing marked this pull request as ready for review April 3, 2024 21:37
@angelahuqing angelahuqing requested a review from DRickard April 4, 2024 16:44
@angelahuqing angelahuqing merged commit 3ebea0e into main Apr 4, 2024
1 check passed
@angelahuqing angelahuqing deleted the SERV-1063 branch April 4, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants