Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-1018] Created basic testing #3

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[SERV-1018] Created basic testing #3

merged 3 commits into from
Feb 21, 2024

Conversation

angelahuqing
Copy link
Contributor

No description provided.

Updated main.go to be testable and included running test in GA workflow
ksclarke
ksclarke previously approved these changes Feb 15, 2024
DRickard
DRickard previously approved these changes Feb 15, 2024
@ksclarke
Copy link
Member

@angelahuqing You don't have to update this PR with this, but for future PRs, would you write a little in the description box so we know a little about what we're about to review?

Add newline after pkill
@angelahuqing angelahuqing dismissed stale reviews from DRickard and ksclarke via dc1dce1 February 15, 2024 21:35
@angelahuqing angelahuqing merged commit 0b85b09 into main Feb 21, 2024
1 check passed
@angelahuqing angelahuqing deleted the SERV-1018 branch February 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants