Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERV-1031] Add TestContainers to CI Build #11

Merged
merged 15 commits into from
Apr 11, 2024
Merged

[SERV-1031] Add TestContainers to CI Build #11

merged 15 commits into from
Apr 11, 2024

Conversation

ksclarke
Copy link
Member

@ksclarke ksclarke commented Apr 11, 2024

  • Build container in CI for testing
  • Use testcontainers for testing
  • Update with various small syntax/formatting/name cleanups
  • Switch to using Alpine container instead of 'scratch' (there is a shell!)
  • Use port 8888 (habit, since I think of 8080 as Tomcat)

@ksclarke ksclarke self-assigned this Apr 11, 2024
@ksclarke ksclarke marked this pull request as ready for review April 11, 2024 20:11
@ksclarke ksclarke requested a review from a team as a code owner April 11, 2024 20:11
@ksclarke ksclarke changed the title [SERV-1031] KSC test branch [SERV-1031] Add TestContainers to CI Build Apr 11, 2024
README.md Outdated Show resolved Hide resolved
@ksclarke ksclarke requested a review from DRickard April 11, 2024 21:04
@ksclarke ksclarke merged commit bb85f6f into main Apr 11, 2024
1 check passed
@ksclarke ksclarke deleted the SERV-1031-KSC branch April 11, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants