feat: APPS-2395 og identifier plus external item record electronic locator #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jendiamond
force-pushed
the
APPS-2395_og-identifier-plus-external-item-record_electronic-locator
branch
from
fbb9d9f to
99ba26b
Compare
jendiamond
force-pushed
the
APPS-2395_og-identifier-plus-external-item-record_electronic-locator
branch
from
99ba26b to
d720c69
Compare
pghorpade
requested changes
Jan 11, 2024
config/locales/blacklight.en.yml
Outdated
| @@ -13,9 +13,11 @@ en: | |||
| normalized_date_sim: 'Normalized Date' | |||
| rights_country: 'Rights (country of creation)' | |||
| services_contact: 'Rights services contact' | |||
| electronic_locator: 'External item record' | |||
There was a problem hiding this comment.
we dont need this on the index page.
config/locales/hyrax.en.yml
Outdated
| @@ -29,6 +29,7 @@ en: | |||
| publisher_tesim: Publisher | |||
| rights_statement_tesim: Rights Statement | |||
| subject_tesim: Subject | |||
| electronic_locator: External item record | |||
| @@ -64,6 +66,7 @@ en: | |||
| rights_holder: 'Rights Holder' | |||
| rights_statement: 'Copyright Status' | |||
| services_contact: 'Rights services contact' | |||
| electronic_locator: External item record | |||
There was a problem hiding this comment.
remove it from under simple form.
config/locales/simple_form.en.yml
Outdated
| @@ -9,3 +9,4 @@ simple_form: | |||
| rights_country: 'Rights (country of creation)' | |||
| rights_holder: 'Rights Holder' | |||
| services_contact: 'Rights services contact' | |||
| electronic_locator: 'External item record' | |||
There was a problem hiding this comment.
why are we adding it here?
There was a problem hiding this comment.
I thought this was the edit form. I'll remove it.
| @@ -56,6 +56,7 @@ | |||
| expect(page).to have_content "uclamss_1387_b112_40911-1" # local_identifier | |||
| expect(page).to have_content "[between 1942-1947]" # date_created | |||
| expect(page).to have_content "Editor-1" | |||
| expect(page).to have_content "http://test.url/external/item/record" # electronic_locator | |||
There was a problem hiding this comment.
should it be testing for identifier content too?
…port_and_show_work_spec
…lt this adds it to the form in edit collection
pghorpade
deleted the
APPS-2395_og-identifier-plus-external-item-record_electronic-locator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2395
Work
Collection:
