Skip to content

Conversation

@ruaridhg
Copy link
Contributor

@ruaridhg ruaridhg commented May 19, 2025

Set a timeout for connecting to the actual Azure PublicClientApplication of 10 seconds since running locally from mirsg-upgrades it worked with 0.1 seconds timeout.

Unfortunately, need to merge every time I test out these fixes unless there's an easier way to test out the cron job like pointing it at a branch I keep open?

Original error was fixed by previous timeout PR #33, but now the cron job hangs

@ruaridhg ruaridhg requested a review from a team May 19, 2025 13:40
@drmatthews
Copy link
Contributor

You should be able to pip install from a branch by adding @branch-name to https://github.com/UCL-MIRSG/UCLMedicalImagingEnv/blob/a122ab59ed1fd4ee1774234d700929b104260458/.github/playbooks/save_email_lists.yml#L42. Not tested it though.

@ruaridhg
Copy link
Contributor Author

You should be able to pip install from a branch by adding @branch-name to https://github.com/UCL-MIRSG/UCLMedicalImagingEnv/blob/a122ab59ed1fd4ee1774234d700929b104260458/.github/playbooks/save_email_lists.yml#L42. Not tested it though.

Yep, I've been doing that for mirsg-upgrades so probably worth doing in UCLMedicalImagingEnv until I can figure out where it's going wrong

@ruaridhg ruaridhg marked this pull request as draft May 19, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants