Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Add live page editor #109

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Add live page editor #109

wants to merge 15 commits into from

Conversation

kn4a-com
Copy link
Collaborator

No description provided.

@kn4a-com kn4a-com requested a review from Typiqally June 26, 2023 14:14
@kn4a-com kn4a-com self-assigned this Jun 26, 2023
"apexcharts": "^3.37.3",
"axios": "^1.4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove axios, is not necessary


onMounted(async () => {
try {
const response = await axios.get(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use existing API class.

import CompetenceProfileComponent from "@/components/CompetenceProfile.vue"
import CompetenceProfileLegend from "@/components/CompetenceProfileLegend.vue"
import CompetenceGraph from "@/components/CompetenceGraph.vue"
import { computed, onMounted, Ref, ref } from "vue"
import RoundLoader from "@/components/RoundLoader.vue"
import EnrollmentTermButtons from "@/components/EnrollmentTermButtons.vue"
// import EnrollmentTermButtons from "@/components/EnrollmentTermButtons.vue"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove uncommented code

<EnrollmentTermButtons
:terms="terms"
@on-term-selected="setTermFilter" />
<!-- <EnrollmentTermButtons
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove uncommented code

@Typiqally Typiqally changed the title Feat/57 page editor Add live page editor Jun 27, 2023
@NealGeilen NealGeilen marked this pull request as ready for review June 27, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants