Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npm7 #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support npm7 #275

wants to merge 1 commit into from

Conversation

falsandtru
Copy link

Fixes #273

@cartant Can you merge?

@cartant
Copy link
Contributor

cartant commented Mar 15, 2021

I'm not going to merge this.

You have an issue because you are using a specific, pre-release version of TypeScript and I guess that npm - unlike Yarn - doesn't provide a mechanism - like resolutions - to deal with the fact that it deems the version to not match the (wide!) semver range.

AFAICT, the point of the changes npm version 7 was not to force packages to removal their peerDependencies. Maybe that was their intention, but I doubt it. Anyway, that would require further investigation and I don't have the time for that, ATM.

Maybe you should use npm's --legacy-peer-deps option? ATM, I don't think removing peerDependencies is the solution.

@falsandtru
Copy link
Author

I feel the current peerDependencies feature is different from the feature we need. So I think you don't have to keep peerDependencies. So if you can't find the correct solution, I think peerDependencies should be removed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install on npm 7
2 participants