Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple ambient declarations for same module #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arshaw
Copy link

@arshaw arshaw commented Jun 25, 2019

Writing ambient modules introduces the possibility of having multiple module declarations of the same name. dts-bundle chokes on this and says "already got export for...". I've modified the code to keep track of an array of module definitions in order to accommodate this use case. Fixes #72

It's unclear to me if the "already got export for" error is ever desirable for non-ambient modules, but my gut tells me no.

CC @eddow

@arshaw
Copy link
Author

arshaw commented Jun 25, 2019

Travis is failing due to reasons unrelated to my code:

Running "mochaTest:all" (mochaTest) task
Warning: /home/travis/build/TypeStrong/dts-bundle/node_modules/grunt-mocha-test/node_modules/mocha/node_modules/debug/src/node.js:120
exports.inspectOpts = Object.keys(process.env).filter(key => {
                                                          ^^
Unexpected token =>� Use --force to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"already got export for:"
1 participant