-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable transformations #582
Conversation
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Preview the changes: https://turinglang.org/docs/pr-previews/582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor stuff. I like these docs a lot!
Co-authored-by: Will Tebbutt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I had a few small comments, but they are minor enough that I'm happy to merge as-is if need be.
Co-authored-by: Markus Hauru <[email protected]>
54c584f
to
8f159e9
Compare
I'll leave this up a few more days to see if anybody has more input before merging:) |
This PR adds a series of new docs on:
Comments are welcome:)
PS. I know that there is some subtlety with the Turing.jl HMC sampling section because the print statements don't actually happen during the sampling, they occur when
values_as_in_model
is called (post-sampling) to collect the values. I figured it's ok to gloss over that, though, because it's still true that HMC sampling occurs entirely in unconstrained space.