Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Turing v0.35 #559

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Update to Turing v0.35 #559

merged 8 commits into from
Nov 26, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Nov 25, 2024

I suspect this might yet crash and burn because of the Bijectors stuff, but have to try it.

It seems to be fine although we are restricted to Julia 1.10 and Turing 0.35.1 (not 0.35.2), as the latter bumps Bijectors compat to 0.14 which causes a bunch of dependency constraints that I didn't dig into. My suspicion is that all of the upgrades (Julia -> 1.11 and Turing -> 0.35.2) are contingent on TuringLang/Bijectors.jl#341 being merged.

This PR also updates the Bayesian neural network tutorial to work with Mooncake. It didn't work out of the box, I think that this was because of mixed-precision floating point arithmetic. Wrapping the neural network parameters in Lux.f32 (see https://lux.csail.mit.edu/stable/api/Lux/utilities#Updating-Floating-Point-Precision) allowed AD and inference to run locally.

I'm fairly confident that the docs should build now.

Closes #521.

Closes #541.

@penelopeysm penelopeysm marked this pull request as draft November 25, 2024 19:04
Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/559
Please avoid using the search feature and navigation bar in PR previews!

@penelopeysm penelopeysm marked this pull request as ready for review November 26, 2024 18:03
@penelopeysm penelopeysm requested a review from yebai November 26, 2024 18:03
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thanks @penelopeysm!

@penelopeysm penelopeysm merged commit d42a408 into master Nov 26, 2024
4 checks passed
@penelopeysm penelopeysm deleted the py/v0.35 branch November 26, 2024 18:10
@penelopeysm penelopeysm mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare update for Turing v0.35 Replace Tracker with Mooncake in Bayesian neural networks example
3 participants