Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save CSV #44

Closed
wants to merge 6 commits into from
Closed

save CSV #44

wants to merge 6 commits into from

Conversation

JaimeRZP
Copy link
Member

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all the formatting comments?:)

docs/make.jl Outdated
Comment on lines 5 to 17
modules = [TuringCallbacks],
authors = "Tor",
repo = "https://github.com/TuringLang/TuringCallbacks.jl/blob/{commit}{path}#L{line}",
sitename = "TuringCallbacks.jl",
format = Documenter.HTML(;
prettyurls = get(ENV, "CI", "false") == "true",
canonical = "https://turinglang.github.io/TuringCallbacks.jl",
assets = String[],
),
pages=[
"Home" => "index.md",
],
pages = ["Home" => "index.md"],
)

deploydocs(;
repo="github.com/TuringLang/TuringCallbacks.jl",
)
deploydocs(; repo = "github.com/TuringLang/TuringCallbacks.jl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all unrelated to the proposed changes, no?

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6473445) 48.14% compared to head (584ed62) 58.91%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #44       +/-   ##
===========================================
+ Coverage   48.14%   58.91%   +10.77%     
===========================================
  Files           6        8        +2     
  Lines         135      185       +50     
===========================================
+ Hits           65      109       +44     
- Misses         70       76        +6     
Files Coverage Δ
ext/TuringCallbacksTuringExt.jl 100.00% <100.00%> (ø)
src/TuringCallbacks.jl 33.33% <ø> (ø)
src/utils.jl 100.00% <100.00%> (ø)
src/callbacks/tensorboard.jl 87.80% <91.48%> (+11.33%) ⬆️
src/callbacks/save.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaimeRZP and others added 2 commits October 12, 2023 17:36
* added more tests

* added support for filtering extras, computing stats for extras, and for adding hyperparameters

* bump versions of Turing and TensorBoardLogger now that it supports hyperparams

* added automatic recording of hyperparms for some Turing samplers, and
improved testing of this

* added useful comment on where i got that weird test from

* fixed tests + added test for MH, which does not currently have hyperparams

* bump minor version since this is breaking

* updated docstring for TensorBoardLogger

Co-authored-by: Tor Erlend Fjelde <[email protected]>
* added more tests

* added support for filtering extras, computing stats for extras, and for adding hyperparameters

* bump versions of Turing and TensorBoardLogger now that it supports hyperparams

* added automatic recording of hyperparms for some Turing samplers, and
improved testing of this

* added useful comment on where i got that weird test from

* fixed tests + added test for MH, which does not currently have hyperparams

* bump minor version since this is breaking

* updated docstring for TensorBoardLogger

Co-authored-by: Tor Erlend Fjelde <[email protected]>
@JaimeRZP
Copy link
Member Author

closed in favour of #49

@JaimeRZP JaimeRZP closed this Oct 12, 2023
@yebai yebai deleted the save_cb branch October 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants