Fix TuringLang/DynamicPPL.jl#27 (#1076)

* Fix TuringLang/DynamicPPL.jl#27 * Add regression test * Fix test error on Julia 1.0
TuringLang · Jan 16, 2020 · f91cbc2 · f91cbc2
1 parent 1dc1158
commit f91cbc2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/inference/Inference.jl b/src/inference/Inference.jl
@@ -696,7 +696,7 @@ function dot_assume(
     var::AbstractMatrix,
     vi::VarInfo,
 )
-    @assert dim(dist) == size(var, 1)
+    @assert length(dist) == size(var, 1)
     r = get_and_set_val!(vi, vns, dist, spl)
     lp = sum(logpdf_with_trans(dist, r, istrans(vi, vns[1])))
     var .= r

diff --git a/src/inference/hmc.jl b/src/inference/hmc.jl
@@ -459,7 +459,7 @@ function dot_assume(
     var::AbstractMatrix,
     vi::VarInfo,
 )
-    @assert dim(dist) == size(var, 1)
+    @assert length(dist) == size(var, 1)
     updategid!.(Ref(vi), vns, Ref(spl))
     r = vi[vns]
     var .= r

diff --git a/test/inference/hmc.jl b/test/inference/hmc.jl
@@ -183,4 +183,14 @@ include(dir*"/test/test_utils/AllUtils.jl")
         @test sample(gdemo_default, alg2, 300) isa Chains
         @test sample(gdemo_default, alg3, 300) isa Chains
     end
+
+    @turing_testset "Regression tests" begin
+        # https://github.com/TuringLang/DynamicPPL.jl/issues/27
+        @model mwe(::Type{T}=Float64) where {T<:Real} = begin
+            m = Matrix{T}(undef, 2, 3)
+            @. m ~ MvNormal(zeros(2), 1)
+        end
+
+        @test sample(mwe(), HMC(0.2, 4), 1_000) isa Chains
+    end
 end