Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - CompatHelper: bump compat for "ChainRulesCore" to "0.10" #255

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 2, 2021

This pull request changes the compat entry for the ChainRulesCore package from 0.9.7 to 0.9.7, 0.10.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2021-06-02-00-21-39-041-345571022 branch from 118ca95 to 5fe18a1 Compare June 2, 2021 00:21
@willtebbutt
Copy link
Member

Is anyone working to get this merged? Would be helpful to get it sorted, as it's currently blocking JuliaGaussianProcesses/AbstractGPs.jl#160 I believe.

@devmotion
Copy link
Member

Unfortunately, this always takes a while since one has to update (and often fix) DistributionsAD and Bijectors. It took me a while to make all tests pass again on DistributionsAD again (some updates in SpecialFunctions and Zygote both broke and fixed different things) but I made a new release with updated ChainRules just a few hours ago. So now some of the fixes have to be applied to Bijectors as well and then one can push through this PR.

@devmotion
Copy link
Member

Opened a PR to Bijectors: TuringLang/Bijectors.jl#182

@devmotion
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 4, 2021
@devmotion
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 4, 2021
This pull request changes the compat entry for the `ChainRulesCore` package from `0.9.7` to `0.9.7, 0.10`.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: David Widmann <[email protected]>
@bors bors bot changed the title CompatHelper: bump compat for "ChainRulesCore" to "0.10" [Merged by Bors] - CompatHelper: bump compat for "ChainRulesCore" to "0.10" Jun 4, 2021
@bors bors bot closed this Jun 4, 2021
@bors bors bot deleted the compathelper/new_version/2021-06-02-00-21-39-041-345571022 branch June 4, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants