-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many more tests and test fixes #32
Conversation
9b8a3be
to
887eb5a
Compare
f7efd8a
to
9ea5cf1
Compare
So the tests here are taking too long, Travis is timing out. GitHub actions have a time limit of 6 hours so I am switching. There is also a mysterious segfault which happens in different places in different operating systems and doesn't happen when I try to reduce the tests. I am not sure what to do to avoid them but I found that simply re-ordering the tests can avoid the issue. This is definitely an issue upstream in Julia itself but without a MWE, I can't report a bug that takes 1 hour to reproduce. Let's see. |
I will merge and release based on local tests passing when broken down into pieces. I will come back to fix CI here later. I know this is not ideal, but if some bug pops up in real code, I promise to track it down as soon as possible :) |
This PR builds on #19 and #29 and adds many more tests and test fixes. There is no new functionality here.