Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to Distributions 0.24.12 #150

Closed
wants to merge 2 commits into from

Conversation

devmotion
Copy link
Member

This PR updates DistributionsAD to Distributions >= 0.24.12. The latest version of Distributions contains many things that previously had to be fixed in DistributionsAD and therefore allows us to remove a large part of DistributionsAD. E.g., it supports automatically

This allows us e.g. to remove the overly optimistic logpdf pullbacks and fixes #121 since Distributions now contains the fix suggested in #121 (comment).

@devmotion
Copy link
Member Author

Seems that eltype(::Type{<:TrackedArray}) isa TrackedReal causes problems with Dirichlet and the Dirichlet tests for ReverseDiff yield the same errors as in #146. Might be better to remove the Dirichlet changes from this PR.

@devmotion
Copy link
Member Author

The ReverseDiff adjoints for simplex_logpdf are wrong, but it seems that they are not responsible for the ReverseDiff test failures.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @devmotion - it looks good to me!

@yebai
Copy link
Member

yebai commented Jan 29, 2021

@devmotion
Copy link
Member Author

I assume the test failures are (at least partly) fixed by #151.

@yebai
Copy link
Member

yebai commented Aug 18, 2021

@devmotion Just a gentle reminder - happy to merge this once the merge conflicts are resolved and CI passing.

@devmotion
Copy link
Member Author

I'll close this since it is partly covered by #198 and it is probably cleaner to make a new PR for the remaining changes in this PR.

@devmotion devmotion closed this Aug 31, 2021
@yebai yebai deleted the dw/latest_distributions branch October 3, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of pullback for logpdf is is overly optimistic
2 participants