fix rng argument position in tests

TuringLang · Oct 24, 2023 · 5dd434d · 5dd434d
1 parent 7a92708
commit 5dd434d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/test/inference/advi_distributionsad.jl b/test/inference/advi_distributionsad.jl
@@ -24,7 +24,7 @@ using Test
             seed = (0x38bef07cf9cc549d)
             rng  = StableRNG(seed)
 
-            modelstats = modelconstr(realtype; rng)
+            modelstats = modelconstr(rng, realtype)
             @unpack model, μ_true, L_true, n_dims, is_meanfield = modelstats
 
             T, η = is_meanfield ? (5_000, 1e-2) : (30_000, 1e-3)

diff --git a/test/interface/advi.jl b/test/interface/advi.jl
@@ -6,7 +6,7 @@ using Test
     rng  = StableRNG(seed)
 
     @testset "with bijector"  begin
-        modelstats = normallognormal_meanfield(Float64; rng)
+        modelstats = normallognormal_meanfield(rng, Float64)
 
         @unpack model, μ_true, L_true, n_dims, is_meanfield = modelstats
 
@@ -31,7 +31,7 @@ using Test
     end
 
     @testset "without bijector"  begin
-        modelstats = normal_meanfield(Float64; rng)
+        modelstats = normal_meanfield(rng, Float64)
 
         @unpack model, μ_true, L_true, n_dims, is_meanfield = modelstats
 

diff --git a/test/interface/optimize.jl b/test/interface/optimize.jl
@@ -6,7 +6,7 @@ using Test
     rng  = StableRNG(seed)
 
     T = 1000
-    modelstats = normallognormal_meanfield(Float64; rng)
+    modelstats = normallognormal_meanfield(rng, Float64)
 
     @unpack model, μ_true, L_true, n_dims, is_meanfield = modelstats
 

diff --git a/test/models/normal.jl b/test/models/normal.jl
@@ -17,7 +17,7 @@ function LogDensityProblems.capabilities(::Type{<:TestNormal})
     LogDensityProblems.LogDensityOrder{0}()
 end
 
-function normal_fullrank(realtype; rng = default_rng())
+function normal_fullrank(rng::Random.AbstractRNG, realtype::Type)
     n_dims = 5
 
     μ = randn(rng, realtype, n_dims)
@@ -29,7 +29,7 @@ function normal_fullrank(realtype; rng = default_rng())
     TestModel(model, μ, L, n_dims, false)
 end
 
-function normal_meanfield(realtype; rng = default_rng())
+function normal_meanfield(rng::Random.AbstractRNG, realtype::Type)
     n_dims = 5
 
     μ = randn(rng, realtype, n_dims)

diff --git a/test/models/normallognormal.jl b/test/models/normallognormal.jl
@@ -26,7 +26,7 @@ function Bijectors.bijector(model::NormalLogNormal)
         [1:1, 2:1+length(μ_y)])
 end
 
-function normallognormal_fullrank(realtype; rng = default_rng())
+function normallognormal_fullrank(rng::Random.AbstractRNG, realtype::Type)
     n_dims = 5
 
     μ_x = randn(rng, realtype)
@@ -43,12 +43,12 @@ function normallognormal_fullrank(realtype; rng = default_rng())
     Σ = Σ |> Hermitian
 
     μ = vcat(μ_x, μ_y)
-    L = cholesky(Σ).L |> LowerTriangular
+    L = cholesky(Σ).L
 
     TestModel(model, μ, L, n_dims+1, false)
 end
 
-function normallognormal_meanfield(realtype; rng = default_rng())
+function normallognormal_meanfield(rng::Random.AbstractRNG, realtype::Type)
     n_dims = 5
 
     μ_x  = randn(rng, realtype)