ReadMe for consctructors #329
Conversation
Co-authored-by: Hong Ge <[email protected]>
…dvancedHMC.jl into ReadMe_constructors
There was a problem hiding this comment.
Good stuff:) Added a few comments.
Also, have we added docs (not in the README, but in docs/) for this?
IMO we should just move all the stuff in the README to docs/ anyways, though this should be done in a separate PR (but in this scenario, it might be worth just moving the section on the convenience contsructors to docs/ maybe?)
Co-authored-by: Tor Erlend Fjelde <[email protected]>
|
Thanks a lot @torfjelde. All good my plan is to merge this and make a release so we can bump the version on Turing! |
Made an issue about it #330 |
Co-authored-by: Hong Ge <[email protected]>
* Update README.md * Update README.md Co-authored-by: Tor Erlend Fjelde <[email protected]> --------- Co-authored-by: Jaime RZ <[email protected]> Co-authored-by: Tor Erlend Fjelde <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* no init_e * format * bug * Bugfix. (#337) * Bugfix. * Update src/constructors.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/abstractmcmc.jl * Update src/abstractmcmc.jl Co-authored-by: Hong Ge <[email protected]> --------- Co-authored-by: Hong Ge <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Updated ReadMe to explain how to use the constructors.
I also spotted a bug in the latest PR and added some tests so it doesn't go unnoticed in the future.