Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing new progress bars #83

Closed
wants to merge 2 commits into from
Closed

Testing new progress bars #83

wants to merge 2 commits into from

Conversation

kaandocal
Copy link
Contributor

@kaandocal kaandocal commented Sep 1, 2021

This is a proposed fix for #82 (definitely WIP). I created variants of some ProgressLogging macros that can be used to add children to the current progress bar, see src/logging.jl; these probably belong elsewhere. The main progress bar showing the # of chains completed is still there, but it might make more sense to update it with the avg. % of work done on each process (that will render the ETA more helpful).

I don't have experience with Distributed so some slight modifications might be needed in that case.

EDIT: Any opinions about ProgressMeter.jl?

@devmotion
Copy link
Member

EDIT: Any opinions about ProgressMeter.jl?

We replaced it with ProgressLogging 😛 The main advantage of ProgressLogging is that it uses the Julia logging system and works with different frontends (eg TerminalLogger, ConsoleProgressMonitor, Juno, VSCode). However, there are still things missing/unpolished in the ProgressLogging API, as the references in the linked issue show, and some things are not supported by the loggers.


##

using ProgressLogging: _asprogress, ProgressString, ProgressLevel, uuid4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the use of these internals indicates that these extensions should be discussed and potentially be added in ProgressLogging but not in AbstractMCMC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No doubt, I will test these extensions and may open a PR in ProgressLogging later, this is just a quick hack

@kaandocal kaandocal closed this by deleting the head repository Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants