Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method ambiguity issues #123

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Fix method ambiguity issues #123

merged 3 commits into from
Jun 20, 2023

Conversation

devmotion
Copy link
Member

Alternative to #120 which keeps the current functionality.

@torfjelde Do you have a MWE of the ambiguity issues? Or can confirm that this PR would fix the issues you ran into?

src/interface.jl Outdated Show resolved Hide resolved
src/interface.jl Outdated Show resolved Hide resolved
src/interface.jl Outdated Show resolved Hide resolved
src/interface.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (e149f9f) 97.33% compared to head (ffb7b43) 97.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   97.33%   97.37%   +0.04%     
==========================================
  Files           8        8              
  Lines         300      305       +5     
==========================================
+ Hits          292      297       +5     
  Misses          8        8              
Impacted Files Coverage Δ
src/interface.jl 95.45% <100.00%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@torfjelde
Copy link
Member

I'll have to dig out those examples; it's been a while. But will try to get around to it sometime today.

@devmotion
Copy link
Member Author

Were you able to find (and run?) the examples?

@torfjelde
Copy link
Member

No, sorry haven't done it yet. The original examples in #120 are from MCMCTempering.jl which I haven't done in a while. This PR most certainly helps with the overall issue we've discussed, whether or not it actuallly solves the particular ambiguity I ran into.

@devmotion
Copy link
Member Author

Should we merge then maybe merge the PR and revisit #120 (or some variant) if problems show up again?

@torfjelde
Copy link
Member

I'm happy with that:) I have NeurIPS reviews over the next few weeks, but once that's done I'll revisit MCMCTempering, and so might be able to provide some cases in #120 then 👍 But for now, let's just merge this.

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David:)

@devmotion devmotion merged commit d7c549f into master Jun 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the dw/bundle_samples branch June 20, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants