Upgrade monorepolint and rework its config to match the new pnpm work #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfedderly
commented
Dec 19, 2023
| }); | ||
| return distanceInKm <= maxDistance; | ||
| } | ||
| ); |
There was a problem hiding this comment.
Had to make changes in this file to get the build to pass? Not sure what's up with that.
There was a problem hiding this comment.
Using @types/rbush in future may help resolve this
mfedderly
requested review from
smallsaucepan and
twelch
and removed request for
smallsaucepan
twelch
approved these changes
Dec 19, 2023
|
Awesome! Thanks @mfedderly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also required an upgrade to husky to get the pre-commit hooks to work
Seems like it also regenerated all the READMEs (script had to get fixed) from the jsdocs in the various packages