Relocate geojson-rbush module into turf monorepo for easier maintenance #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfedderly
reviewed
Oct 29, 2023
mfedderly
approved these changes
Nov 2, 2023
…he turf monorepo for easier maintenance. Not building yet. Only establishing a clear snapshot for handover between the repos.
…ment - in case we need to add a vanilla rbush module one day.
… changes to readme for now as it should eventually be generated automatically from the code. Will work on JSDocs at the same time as we start using this module from other places within the monorepo.
smallsaucepan
force-pushed
the
geojson-rbush-into-monorepo
branch
from
5ca7ed8
to
2511529
Compare
smallsaucepan
added a commit
to smallsaucepan/turf
that referenced
this pull request
Nov 3, 2023
smallsaucepan
added a commit
that referenced
this pull request
Nov 3, 2023
… and regenerate all readmes (#2528) * Fix generate-docs to work with tsx (add extension, fix a few TS errors). monorepolint rule changed to reflect ts file extension. Add node to eslint env config so editors can find definitions of node variables (such as __dirname) used in scripts. * Change project root docs target to use tsx and generate-docs.ts. Tighten up gnerates-docs.ts folder globbing - was inadvertently matching when my working parent directory was named something like ~/code/turf-docs-test/... interpreting docs-test as a package name. Reworded readme postfix content to be clearer on the different ways of installing. Updated a few links from http to https. * Result of running yarn docs from the project root with the previously committed changes. * Applying recently merged changes (from PR #2523) to this new module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to bring the currently standalone geojson-rbush repo in to the Turf monorepo. Per the standalone project it's not meant to be used outside of Turf, so might as well make it part of the overall project for ease of integration and maintenance.
Not sure if it's been kept separate due to some project history. Did make attempts to find out though wasn't able to establish anything concrete.
This PR would be part one of a two step process. Once this PR is merged and the module published (presumably as part of 7.0.0-alpha.3) packages that depend on geojson-rbush can be switched over to use @turf/rbush for alpha.4
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Submitting a new TurfJS Module.
Sort of? This is essentially an existing module. Retained README, etc as best as possible from standalone repo. Can revise if need be.