Upgrade lerna, et al to address security vulnerabilities, modernise build environment#2507
Merged
mfedderly merged 9 commits intoTurfjs:masterfrom Oct 6, 2023
Merged
Conversation
…mmand no longer required. Seems to build and test ok. May need some tweaking. Will add build caching at a later date.
…ilities. Had to wrap body of script so as be async, though otherwise unchanged.
…ng. Remove redundant packages setting from lerna.json (will default to packages setting in package.json instead). Have to add --npm-path to all npm-run-all calls so that lerna doesn't accidentally end up being used as the npm binary. mysticatea/npm-run-all#218 and lerna/lerna#1842 have more details.
…ges in previous commit.
mfedderly
approved these changes
Oct 6, 2023
| : glob.sync(path.join(__dirname, "..", "packages", "turf-*", "package.json")); | ||
| (async () => { | ||
| // documentation v14 has moved to ESM so need to import as if async, and wrap | ||
| // in an IIFE as top level async not allowed. |
| @@ -0,0 +1,52 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
I'll admit to not being fully up to speed on nx, but this looks sane to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading lerna and a couple of other build related libraries. Addresses potential security vulnerabilities (from 3rd party libraries):
Also modernises the build environment, for example meaning we can take advantage of lerna caching. Our configuration may need some tweaking esp around publishing to npm, though this should be a good base to work from.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Submitting a new TurfJS Module.
n/a