Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines with a 180 degree angle between them should be considered parallel (turf-boolean-parallel) #2475

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Lines with a 180 degree angle between them should be considered parallel (turf-boolean-parallel) #2475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
540a821
Lines with a 180 degree angle between them are considered parallel
mracette Aug 24, 2023
60a9925
Add simple verticals test
mracette Aug 27, 2023
8c2d806
Add failing test case for 3d lines
mracette Aug 28, 2023
829e678
Merge branch 'master' into boolean-parallel-fix
mracette Aug 31, 2023
0188874
Merge branch 'master' into boolean-parallel-fix
mracette Sep 12, 2023
6a143fa
Fix verticals 3d test
mracette Sep 19, 2023
a1aff2d
Merge branch 'master' into boolean-parallel-fix
mracette Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/turf-boolean-parallel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function booleanParallel(
function isParallel(segment1: Position[], segment2: Position[]) {
var slope1 = bearingToAzimuth(rhumbBearing(segment1[0], segment1[1]));
var slope2 = bearingToAzimuth(rhumbBearing(segment2[0], segment2[1]));
return slope1 === slope2;
return slope1 === slope2 || (slope2 - slope1) % 180 === 0;
}

/**
Expand Down
27 changes: 27 additions & 0 deletions packages/turf-boolean-parallel/test/true/opposites.geojson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[0, 0],
[1, 0]
]
}
},
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[1, 0],
[0, 0]
]
}
}
]
}
27 changes: 27 additions & 0 deletions packages/turf-boolean-parallel/test/true/verticals.geojson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[0, 0],
[0, 1]
]
}
},
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[1, 0],
[1, 1]
]
}
}
]
}
27 changes: 27 additions & 0 deletions packages/turf-boolean-parallel/test/true/verticals3d.geojson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[-10, 20, 0],
[-10, 10, 0]
]
}
},
{
"type": "Feature",
"properties": {},
"geometry": {
"type": "LineString",
"coordinates": [
[-20, 20, 0],
[-20, 10, 0]
]
}
}
]
}