Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(2679): Fix issue with download buttons missing from large files #2690

Merged
merged 7 commits into from
Jan 7, 2025
Merged

fix(2679): Fix issue with download buttons missing from large files #2690

merged 7 commits into from
Jan 7, 2025

Conversation

islathehut
Copy link
Collaborator

@islathehut islathehut commented Jan 6, 2025 •
edited
Loading

  • Fixes download button bug
  • Updates logger for improved formatting of CIDs and long UInt8Array fields
  • Adds extra warning logs to state manager under bad conditions
  • Updates contrast colors of download progress bar

Screenshot 2025-01-07 at 9 40 58 AM

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut islathehut changed the base branch from develop to 3.0.0 January 6, 2025 19:24
@islathehut
Copy link
Collaborator Author

#2679

@islathehut islathehut marked this pull request as ready for review January 6, 2025 19:24
@islathehut
Copy link
Collaborator Author

I don't know why the regression tests are failing, regression-test:ci passes locally.

@islathehut islathehut merged commit 2ca7119 into 3.0.0 Jan 7, 2025
21 of 26 checks passed
@islathehut islathehut deleted the fix/2679-download-missing branch January 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrastaea adrastaea adrastaea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islathehut @adrastaea