Update orbitdb #2600
Update orbitdb #2600
Conversation
islathehut
force-pushed
the
update-orbitdb
branch
from
6b0cea5 to
0695992
Compare
| @@ -0,0 +1,9 @@ | |||
| root = true | |||
There was a problem hiding this comment.
I added helia as a package which is NOT ideal but it was the fastest way to get it integrated, from my perspective. We should ultimately update it to be a submodule like lfa but I don't have it in me to do it right now.
| @@ -176,7 +176,7 @@ - (void)applicationDidEnterBackground:(UIApplication *)application | |||
| { | |||
| [self stopTor]; | |||
|
|
|||
| NSString * message = [NSString stringWithFormat:@""]; | |||
| NSString * message = [NSString stringWithFormat:@"app:close"]; | |||
There was a problem hiding this comment.
This was just to get rid of an error that didn't break anything, it was just annoying.
There was a problem hiding this comment.
When an older client that has updated to this commit is loaded, the invitationLink will be invalid due to the PeerID being invalid.
| @@ -16,6 +16,7 @@ jobs: | |||
| DISPLAY: ":99.0" | |||
| TEST_MODE: true | |||
| IS_CI: true | |||
| SKIP_BACK_COMPAT_TEST_BRANCHES: '["update-orbitdb"]' | |||
There was a problem hiding this comment.
is this relevant after merging?
There was a problem hiding this comment.
No, I'm gonna update it once we have an alpha.
| @@ -162,19 +159,19 @@ describe('IpfsFileManagerService', () => { | |||
| 2, | |||
| StorageEvents.FILE_UPLOADED, | |||
| expect.objectContaining({ | |||
| cid, | |||
| cid: expect.stringContaining('bafk'), | |||
There was a problem hiding this comment.
What's the deal with this change?
There was a problem hiding this comment.
This just verifies the format of the CID is correct without having to hard code the string. If I remember correctly the CID isn't static per file so having it hard coded was pointless. Don't quote me on that, I haven't touched that logic in a while.
| resolve() | ||
| }, 5000) | ||
| ) | ||
| await sleep(5000) |
There was a problem hiding this comment.
why are we sleeping here?
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: