-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(2523): Improve logging, primarily on desktop #2518
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9a372e8
Add better formatted logger to logger package
islathehut 4374158
Use new logger in state-manager
islathehut 94e662d
Use new logger in backend
islathehut bd8da81
First round of desktop log updates
islathehut 6bccb85
Ensure renderer logs also show up in browser
islathehut 6f71eb3
Fix tests
islathehut 7e08edb
Merge branch 'develop' into logging-improvements
cd54893
Remove all references to the old logger
islathehut d16f2f1
Add docs and clean up logger code
islathehut ca4b0e3
More log changes and adding timers
islathehut d5fecbd
Replace all usages of console and the old logger, make mobile work we…
islathehut 84696a7
Fix android logging with polyfill
islathehut 97af3c7
Merge branch 'develop' into logging-improvements
islathehut 50f7893
Fix test
islathehut 3845d1e
Add docs to polyfill
islathehut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,9 +108,8 @@ | |
| "dotenv": "8.2.0", | ||
| "events": "^3.2.0", | ||
| "express": "^4.17.1", | ||
| "fetch-retry": "^6.0.0", | ||
| "node-fetch": "^3.3.0", | ||
| "fastq": "^1.17.1", | ||
| "fetch-retry": "^6.0.0", | ||
| "get-port": "^5.1.1", | ||
| "go-ipfs": "npm:[email protected]", | ||
| "http-server": "^0.12.3", | ||
|
|
@@ -124,6 +123,7 @@ | |
| "libp2p": "0.42.2", | ||
| "luxon": "^3.4.4", | ||
| "multiaddr": "^10.0.1", | ||
| "node-fetch": "^3.3.0", | ||
| "orbit-db": "0.29.0", | ||
| "orbit-db-access-controllers": "^0.4.0", | ||
| "orbit-db-identity-provider": "0.5.0", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { shouldPolyfill as shouldPolyfillCanon } from '@formatjs/intl-getcanonicallocales/should-polyfill' | ||
| import { shouldPolyfill as shouldPolyfillLocale } from '@formatjs/intl-locale/should-polyfill' | ||
| import { shouldPolyfill as shouldPolyFillFormat } from '@formatjs/intl-datetimeformat/should-polyfill' | ||
|
|
||
| function polyfill() { | ||
| if (shouldPolyfillCanon()) { | ||
| require('@formatjs/intl-getcanonicallocales/polyfill') | ||
| } | ||
|
|
||
| if (shouldPolyfillLocale()) { | ||
| require('@formatjs/intl-locale/polyfill') | ||
| } | ||
|
|
||
| if (shouldPolyFillFormat()) { | ||
| require('@formatjs/intl-datetimeformat/polyfill') | ||
| require('@formatjs/intl-datetimeformat/locale-data/en') | ||
| } | ||
| } | ||
|
|
||
| polyfill() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the best place for this polyfill. I wanted it to be in mobile since its specific to mobile but the mobile code wasn't being run soon enough, it seems, to run before the logging started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added some doc strings to the this file for clarity.