Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "Download file" button for new users #2679

Open
kingalg opened this issue Dec 24, 2024 · 1 comment
Open

Missing "Download file" button for new users #2679

kingalg opened this issue Dec 24, 2024 · 1 comment
Labels
3.X v3.X bug Something isn't working

Comments

@kingalg
Copy link
Collaborator

kingalg commented Dec 24, 2024

Version: 3.0.0-alpha.1
System: all desktop (on mobiles there is no downloading functionality yet)

Issue: when a new user joins a community in which bigger files have already been uploaded, this user doesn't have the option to download them (there is no "download" button). It's not a consistent behavior, but it appears frequently. It should be easy to reproduce.

Screenshot from 2024-12-23 16-27-08

Note - I add it to the current sprint but it's to be decided if we are fixing this now or in the future.

@kingalg kingalg added bug Something isn't working 3.X v3.X labels Dec 24, 2024
@kingalg kingalg added this to Quiet Dec 24, 2024
@kingalg kingalg moved this to Sprint in Quiet Dec 24, 2024
@islathehut
Copy link
Collaborator

My steps for reproducing

  1. Create a new community
  2. Connect another peer to the new community
  3. While both are online send multiple files and images from one user to another, including at least 2 that are not auto downloaded
  4. Start downloading one of the large files and then cancel the download
  5. Create another peer and connect them to the community

What I saw was that the file I had not cancelled has no download button on the third peer but does appear on the file that was cancelled on the other peer.

Things I've noticed

  • I couldn't get this issue to show up before cancelling a download
  • Adding extra logs I see that the message shows up in the addMessagesSaga but not in the autoDownloadFilesSaga even though they both get triggered by the same events - they should get the same message IDs but the file with the missing button doesn't show up in the list of IDs sent to autoDownloadFilesSaga

@islathehut islathehut moved this from Sprint to In progress in Quiet Jan 2, 2025
@islathehut islathehut moved this from In progress to Waiting for review in Quiet Jan 6, 2025
@islathehut islathehut moved this from Waiting for review to Merged in Quiet Jan 7, 2025
@islathehut islathehut moved this from Merged to Ready for QA in Quiet Jan 7, 2025
@islathehut islathehut moved this from Ready for QA to Merged in Quiet Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.X v3.X bug Something isn't working
Projects
Status: Merged
Development

No branches or pull requests

2 participants