Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump node-gyp to v10 #1788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

branchvincent
Copy link

Fixes #1752

@YasharF
Copy link

YasharF commented May 26, 2024

Hey there, I am curious. What kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ?

@niklasf
Copy link

niklasf commented Jun 6, 2024

Can confirm this solves the issue, builds, and works at least for basic database operations. Tested with --target_arch arm --build-from-source.

@demiankatz
Copy link

I wonder if this might also fix #1762, since the deprecated dependency is coming in courtesy of node-gyp.

@gladykov
Copy link

gladykov commented Jul 2, 2024

This would also fix GHSA-2p57-rm9w-gvfp. All dependencies are fixed down the line.

Current dependency chain to affected package:

image

@netroy
Copy link

netroy commented Jul 8, 2024

I compiled this branch, and then updated n8n to use file: versions of sqlite3, and all integration tests still passed.
Considering that n8n's backend tests do a lot of database calls, I don't think there is going to be any major regression caused by this upgrade.
The upgrade also cleaned up the dependency tree a little bit as a side-bonus 🎉 .

@daniellockyer Can we please have this merged 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install sqlite3 fail if prebuilt unreachable and Python v3.12 is installed
6 participants